chore(gke): Remove deprecated method #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #344, deprecated code was discovered which led to some confusion. It wasn't clear exactly how to remove the deprecated code and ensure tests were still functioning. 1. Rename `GeneratePricingMap` to `ParseSkus` 2. Update `ParseSkus` to be a receiver method on PricingMaps 3. Update `pricingMap.Populate` to return the result of ParseSkus 4. Update pricing map tests to call ParseSkus instead
Pokom
commented
Nov 4, 2024
Comment on lines
+279
to
+282
| if strings.Contains(data.Description, "Confidential") { | ||
| log.Printf("Storage class contains Confidential: %s\n%s\n", storageClass, data.Description) | ||
| continue | ||
| } |
There was a problem hiding this comment.
I'm moving this after the first storageClass check since that one should take priority.
Pokom
commented
Nov 4, 2024
Comment on lines
+643
to
+646
| pricingMap := &PricingMap{ | ||
| Compute: make(map[string]*FamilyPricing), | ||
| Storage: make(map[string]*StoragePricing), | ||
| } |
There was a problem hiding this comment.
Specifically not calling NewPricingMap(...) because that method will also call populate. I'm specifically trying to avoid having to mock out the billing client.
cindy
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #344, deprecated code was discovered which led to some confusion. It wasn't clear exactly how to remove the deprecated code and ensure tests were still functioning.
GeneratePricingMaptoParseSkusParseSkusto be a receiver method on PricingMapspricingMap.Populateto return the result of ParseSkus